Code Review
2017-08-22 10:32:12 UTC
From Dan Kenigsberg <***@redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80756 )
Change subject: tests: improve faking
......................................................................
tests: improve faking
This patch avoids this error due to insufficient faking
AttributeError: 'NoneType' object has no attribute 'notify'
Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Signed-off-by: Francesco Romani <***@redhat.com>
---
M tests/virttests/seal_job_test.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/80756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80756 )
Change subject: tests: improve faking
......................................................................
tests: improve faking
This patch avoids this error due to insufficient faking
AttributeError: 'NoneType' object has no attribute 'notify'
Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Signed-off-by: Francesco Romani <***@redhat.com>
---
M tests/virttests/seal_job_test.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/80756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee9d3fa1aa9b809a65b04b7972f70d6af848a0c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email