Change in vdsm[master]: hooking: move to lib

[Code Review]

From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: hooking: move to lib
......................................................................


Patch Set 1:

are you should its working? it failed..

--
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-pa

[Code Review]

From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: hooking: move to lib
......................................................................


Patch Set 2: Code-Review+1

--
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <***@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahosted.o

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: hooking: move to lib
......................................................................


Patch Set 2: Code-Review+2

--
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <***@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahosted.org

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80842 )

Change subject: hooking: move to lib
......................................................................


hooking: move to lib

As part of broader migration we move hooking.py away from vdsm dir.


Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Signed-off-by: Piotr Kliczewski <***@gmail.com>
---
M Makefile.am
M configure.ac
M lib/vdsm/Makefile.am
A lib/vdsm/hook/Makefile.am
A lib/vdsm/hook/__init__.py
R lib/vdsm/hook/hooking.py
M lib/vdsm/hooks.py
M vdsm.spec.in
M vdsm/Makefile.am
9 files changed, 33 insertions(+), 7 deletions(-)

Approvals:
Piotr Kliczewski: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved



--
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <***@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave