Discussion:
Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...
Code Review
2017-08-22 20:01:06 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................


Patch Set 5:

ci please build

--
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm
Code Review
2017-08-22 21:26:44 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................


Patch Set 5: Code-Review+2 Verified+1

./run_suite.sh -s http://jenkins.ovirt.org/job/vdsm_4.1_check-patch-el7-x86_64/870/ basic-suite-4.1

is successful, this can go it.

--
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorah
Code Review
2017-08-22 21:30:55 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80390 )

Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................


net: Report empty LLDP TLV lists for operationally-down interfaces

Before this patch, a single interface that was never monitored by lldpad
had caused the API level to fail, blocking information about
properly-enabled interfaces.

This change reports interfaces being not in state UP as not
enabled for LLDP with an empty list of TLVs.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Signed-off-by: Dominik Holler <***@redhat.com>
(cherry picked from commit 347eec3c024c76405e60d97f53ef312614797530)
---
M lib/vdsm/network/lldp/info.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve



--
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an e

Loading...