Discussion:
Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network
Code Review
2017-08-23 07:33:13 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: network: remove ip from a nic used by a removed network
......................................................................


Patch Set 2: Code-Review+2

--
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <***@redhat.com>
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lis
Code Review
2017-08-23 07:33:17 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80835 )

Change subject: network: remove ip from a nic used by a removed network
......................................................................


network: remove ip from a nic used by a removed network

Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Signed-off-by: Petr Horacek <***@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1432386
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
M tests/network/func_static_ip_test.py
3 files changed, 83 insertions(+), 19 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve



--
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <***@redhat.com>
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists

Loading...