Discussion:
Change in vdsm[master]: net tests func: Fix IPv4 default route assertion
Code Review
2017-08-22 18:54:33 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net tests func: Fix IPv4 default route assertion
......................................................................


Patch Set 3: Code-Review+2

raising

--
To view, visit https://gerrit.ovirt.org/80777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@li
Code Review
2017-08-22 18:56:32 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80777 )

Change subject: net tests func: Fix IPv4 default route assertion
......................................................................


net tests func: Fix IPv4 default route assertion

The request flag of defaultRoute is not directly related to the net caps
property of ipv4defaultroute.
ipv4defaultroute is true when the network gateway is also the host
default route.
However, a request with defaultRoute set and no gateway is valid,
resulting with a false ipv4defaultroute.

This patch updates the assertion check to be in sync with the
described logic.

Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Signed-off-by: Edward Haas <***@redhat.com>
---
M tests/network/functional/netfunctestlib.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/80777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66ee5173261c84845b325b0b0df3fc91aaf02510
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-l

Loading...