Discussion:
Change in vdsm[master]: net: netinfo: Detect early that an iface is missing
Code Review
2017-08-15 08:54:20 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: netinfo: Detect early that an iface is missing
......................................................................


Patch Set 5: Code-Review+2

raising

--
To view, visit https://gerrit.ovirt.org/80185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac2ab3c1aeb999121e21a6f8624dd2963a1f60c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leave
Code Review
2017-08-15 08:54:30 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80185 )

Change subject: net: netinfo: Detect early that an iface is missing
......................................................................


net: netinfo: Detect early that an iface is missing

While creating the network caps report using netinfo, an expected
iface may be missing. For such scenarios, the network it represents is
skipped and not reported (assumed not to exist).

This patch detects the missing iface earlier.

Change-Id: I0ac2ab3c1aeb999121e21a6f8624dd2963a1f60c
Signed-off-by: Edward Haas <***@redhat.com>
---
M lib/vdsm/network/netinfo/cache.py
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/80185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ac2ab3c1aeb999121e21a6f8624dd2963a1f60c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send a

Loading...