Discussion:
Change in vdsm[master]: net tests: Relocate network (new) functional tests to its ow...
Code Review
2017-08-15 06:24:11 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Relocate network (new) functional tests to its own folder
......................................................................


Patch Set 7: Code-Review+2

raising

--
To view, visit https://gerrit.ovirt.org/79725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd98f89b2e32f4011465574c54b8b7e99282a4c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <***@redhat.com>
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm
Code Review
2017-08-15 06:25:27 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79725 )

Change subject: net tests: Relocate network (new) functional tests to its own folder
......................................................................


net tests: Relocate network (new) functional tests to its own folder

The functional tests are not mixed with other test types (unit and
integration), therefore, moving them to a seperated folder will remove
some uneeded complexity in choosing which tests should run.

Running the unit & integration tests has not changed.
Running the functional requires these commands:
./run_tests.sh -a switch=legacy network/functional/*_test.py
./run_tests.sh -a switch=ovs network/functional/*_test.py

For running legacy, ovs and switch type change tests (but not dpdk ones):
./run_tests.sh -A "switch!='ovs-dpdk'" network/functional/*_test.py

This patch is one step forward in moving all networking tests
to py.test.

Change-Id: I7bd98f89b2e32f4011465574c54b8b7e99282a4c
Signed-off-by: Edward Haas <***@redhat.com>
---
M automation/check-merged.sh
M configure.ac
M tests/network/Makefile.am
A tests/network/functional/Makefile.am
C tests/network/functional/__init__.py
R tests/network/functional/bond_basic_test.py
R tests/network/functional/dhclient_test.py
R tests/network/functional/dns_test.py
R tests/network/functional/dpdk_test.py
R tests/network/functional/net_basic_test.py
R tests/network/functional/net_qos_test.py
R tests/network/functional/net_with_bond_test.py
R tests/network/functional/netfunctestlib.py
R tests/network/functional/netrestore_test.py
R tests/network/functional/rollback_test.py
R tests/network/functional/static_ip_test.py
R tests/network/functional/switch_type_change_test.py
M tests/run_tests_local.sh.in
M vdsm.spec.in
19 files changed, 75 insertions(+), 78 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/79725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bd98f89b2e32f4011465574c54b8b7e99282a4c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <***@redhat.com>
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@l

Loading...