Discussion:
Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows
Code Review
2017-08-17 13:40:00 UTC
Permalink
From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: time: Add a Clock utility for timing complex flows
......................................................................


Patch Set 1: Code-Review+2

--
To view, visit https://gerrit.ovirt.org/80426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Adam Litke <***@redhat.com>
Gerrit-Reviewer: Ala Hino <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe sen
Code Review
2017-08-17 13:40:32 UTC
Permalink
From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: time: Add a Clock utility for timing complex flows
......................................................................


Patch Set 2: Continuous-Integration+1

--
To view, visit https://gerrit.ovirt.org/80426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Adam Litke <***@redhat.com>
Gerrit-Reviewer: Ala Hino <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorah
Code Review
2017-08-17 13:40:36 UTC
Permalink
From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80426 )

Change subject: time: Add a Clock utility for timing complex flows
......................................................................


time: Add a Clock utility for timing complex flows

This helps to record the time for multiple steps in a complex flow and
log the results. This will be used in the next patch for timing extend
disk flow.

Changes from master:
- There is no vdsm.common.time module, adding Clock to utils, near
monotonic_time.

Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Bug-Url: https://bugzilla.redhat.com/1461536
Signed-off-by: Nir Soffer <***@redhat.com>
---
M lib/vdsm/utils.py
A tests/common/time_test.py
2 files changed, 176 insertions(+), 0 deletions(-)

Approvals:
Adam Litke: Looks good to me, but someone else must approve
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve



--
To view, visit https://gerrit.ovirt.org/80426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91d238ebb79d78c625c95892d19718129c015046
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Adam Litke <***@redhat.com>
Gerrit-Reviewer: Ala Hino <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahost
Loading...