Change in vdsm[master]: ovs-dpdk: support ovs 2.7

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: ovs-dpdk: support ovs 2.7
......................................................................


Patch Set 7:

unrelated failure

ERROR: test_with_device (loopback_test.TestDevice)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/testValidation.py", line 191, in wrapper
return f(*args, **kwargs)
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback_test.py", line 42, in test_with_device
with loopback.Device(filename) as device:
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py", line 92, in __enter__
self.attach()
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py", line 56, in attach
raise cmdutils.Error(cmd, rc, out, err)
Error: Command ['losetup', '--find', '--show', '/tmp/tmpzf6_TD/file'] failed with rc=1 out='' err='losetup: /tmp/tmpzf6_TD/file: failed to set up loop device: No such file or directory\n'

--
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an em

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80818 )

Change subject: ovs-dpdk: support ovs 2.7
......................................................................


ovs-dpdk: support ovs 2.7

Compatibility with the old dpdk<portid> naming is broken in ovs 2.7, and as
such a device will not be available for use until a valid dpdk-devargs is
specified.
When adding dpdk devices to ovs bridge, the PCI address must be
set using the 'dpdk-devargs' option.
Device naming is arbitrary.

Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Signed-off-by: Irit Goihman <***@redhat.com>
---
M lib/vdsm/network/link/dpdk.py
M lib/vdsm/network/ovs/driver/__init__.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/network/ovs/switch.py
M vdsm.spec.in
5 files changed, 15 insertions(+), 4 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved



--
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedoraho