Discussion:
Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface
Code Review
2017-08-22 21:27:39 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Introduce the LLDPAD driver with an LLDP interface
......................................................................


Patch Set 6: Code-Review+2 Verified+1

--
To view, visit https://gerrit.ovirt.org/80187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patche
Code Review
2017-08-22 21:30:55 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80187 )

Change subject: net: Introduce the LLDPAD driver with an LLDP interface
......................................................................


net: Introduce the LLDPAD driver with an LLDP interface

The Link Layer Discovery Protocol (LLDP) is a vendor-neutral link layer
protocol in the Internet Protocol Suite used by network devices for
advertising their identity, capabilities, and neighbors on an IEEE 802
local area network, principally wired Ethernet.

This patch introduces an LLDP interface, implemented using the lldpad
service & tool.

Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Signed-off-by: Edward Haas <***@redhat.com>
Signed-off-by: Dominik Holler <***@redhat.com>
(cherry picked from commit 7b47fe3bbac7dd1e126d55b8064f6807819caf5e)
---
M configure.ac
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/lldp/Makefile.am
A lib/vdsm/network/lldp/__init__.py
A lib/vdsm/network/lldp/lldpad.py
A lib/vdsm/network/lldpad/Makefile.am
A lib/vdsm/network/lldpad/__init__.py
A lib/vdsm/network/lldpad/lldptool.py
M static/usr/lib/systemd/system/vdsmd.service.in
A tests/network/lldpad_test.py
M tests/network/nettestlib.py
M vdsm.spec.in
12 files changed, 605 insertions(+), 2 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve



--
To view, visit https://gerrit.ovirt.org/80187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fe

Loading...