Change in vdsm[master]: dpdk: call flush ip only on non dpdk devices

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: dpdk: call flush ip only on non dpdk devices
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/80688/1/lib/vdsm/network/ifacquire.py
File lib/vdsm/network/ifacquire.py:

Line 155: return
Line 156: # TODO: Tell NetworkManager to unmanage this iface.
Line 157: dhclient.kill(iface, family=4)
Line 158: dhclient.kill(iface, family=6)
Line 159: if not dpdk.is_dpdk(iface):
does dhclient run on dpdk iface? wouldn't it be better to bail off early, just as if the iface did not exist?


--
To view, visit https://gerrit.ovirt.org/80688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahosted.or

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80688 )

Change subject: dpdk: add only non dpdk nics to aqcuired ifaces
......................................................................


dpdk: add only non dpdk nics to aqcuired ifaces

Acquirement should not be done on DPDK based ifaces
since the actions are not supported on these devices.

Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Signed-off-by: Irit Goihman <***@redhat.com>
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved



--
To view, visit https://gerrit.ovirt.org/80688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fe