Discussion:
Change in vdsm[master]: virt net: vhost custom property with a wrong net name
Code Review
2017-08-16 08:39:27 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: virt net: vhost custom property with a wrong net name
......................................................................


Patch Set 1: Code-Review+2

--
To view, visit https://gerrit.ovirt.org/80672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I118a40236c7de7ad136d734e4c6653bfce332199
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Arik Hadas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahosted
Code Review
2017-08-16 08:39:31 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80672 )

Change subject: virt net: vhost custom property with a wrong net name
......................................................................


virt net: vhost custom property with a wrong net name

If the network name specified in `vhost' custom property
doesn't correspond to a network contained in the interface object,
ignore it.

Change-Id: I118a40236c7de7ad136d734e4c6653bfce332199
Bug-Url: https://bugzilla.redhat.com/1479872
Signed-off-by: Edward Haas <***@redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/80672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I118a40236c7de7ad136d734e4c6653bfce332199
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Arik Hadas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send

Loading...