Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

[Code Review]

From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: stop using hard coded values for heartbeats
......................................................................


Patch Set 4: Code-Review+2

--
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patch

[Code Review]

From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: stop using hard coded values for heartbeats
......................................................................


Patch Set 5: Continuous-Integration+1

--
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to

[Code Review]

From Yaniv Bronhaim <***@redhat.com>:

Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/78918 )

Change subject: stomp: stop using hard coded values for heartbeats
......................................................................


stomp: stop using hard coded values for heartbeats

We wish to support incoming heartbeats in JSONRPC client
in order to implement reconnect mechanism.
AsyncClient connect method used to send HEARTBEAT header with
hard coded values, which are now configurable and enable both
ways heartbeats.

Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Signed-off-by: Irit Goihman <***@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/stompAsyncClientTests.py
3 files changed, 28 insertions(+), 9 deletions(-)

Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
Irit Goihman: Verified



--
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahosted.o