Change in vdsm[master]: vhostuser: convert macAddr to string

[Code Review]

From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: vhostuser: convert macAddr to string
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/80066/3/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:

Line 298: supervdsm.getProxy().add_ovs_vhostuser_port(
Line 299: ovs_bridge, port, socket_path)
Line 300:
Line 301: def _get_vhostuser_port_name(self):
Line 302: return str(uuid.uuid3(uuid.UUID(self.vmid), str(self.macAddr)))
I don't understand how this casting is required here but not in other users of self.macAddr. What is the complete value of macAddr provided from Engine? How is this related to the host being RHEL-7.4?
Line 303:
Line 304: def _set_parameters_filter(self, filter):
Line 305: for name, value in self._filter_parameter_map():
Line 306: filter.appendChildWithArgs('parameter', name=name, value=value)


--
To view, visit https://gerrit.ovirt.org/80066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4d11a154ffd88523b3d7b19ac87891aac2fba2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Francesco Romani <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-lea