Discussion:
Change in vdsm[master]: net: Extract ethtool to its own module
Code Review
2017-08-15 08:54:09 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: Extract ethtool to its own module
......................................................................


Patch Set 5: Code-Review+2

raising

--
To view, visit https://gerrit.ovirt.org/80068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b5b4a89e8fa6000bcd724d070d51d46d622da0c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedora
Code Review
2017-08-15 08:54:30 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80068 )

Change subject: net: Extract ethtool to its own module
......................................................................


net: Extract ethtool to its own module

ethtool is used to retrieve driver information for a given iface.

This patch extracts the ethtool code to an independent module in order
to ease its usage by other modules and give it a proper scope.

Change-Id: I7b5b4a89e8fa6000bcd724d070d51d46d622da0c
Signed-off-by: Edward Haas <***@redhat.com>
---
A lib/vdsm/network/ethtool.py
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/netinfo/nics.py
A tests/network/ethtool_test.py
M tests/network/ipwrapper_test.py
5 files changed, 104 insertions(+), 37 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/80068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b5b4a89e8fa6000bcd724d070d51d46d622da0c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fe

Loading...