Discussion:
Change in vdsm[master]: net tests: Define switch type parametrize at netfunctestlib
Code Review
2017-08-15 06:24:49 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Define switch type parametrize at netfunctestlib
......................................................................


Patch Set 3: Code-Review+2

raising

--
To view, visit https://gerrit.ovirt.org/80457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b78847a6950660e1b30c0d7e7d4a676351b2a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-leav
Code Review
2017-08-15 06:25:28 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80457 )

Change subject: net tests: Define switch type parametrize at netfunctestlib
......................................................................


net tests: Define switch type parametrize at netfunctestlib

Several parametrize definitions are common to multiple functional test
modules and their definition can be moved to the test lib.

This patch handles the switch type parametrize, future patches will
define new ones to serve the tests.

Change-Id: Id4b78847a6950660e1b30c0d7e7d4a676351b2a8
Signed-off-by: Edward Haas <***@redhat.com>
---
M tests/network/functional/bond_basic_test.py
M tests/network/functional/dhclient_test.py
M tests/network/functional/net_basic_test.py
M tests/network/functional/net_with_bond_test.py
M tests/network/functional/netfunctestlib.py
M tests/network/functional/rollback_test.py
M tests/network/functional/static_ip_test.py
7 files changed, 20 insertions(+), 22 deletions(-)

Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/80457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4b78847a6950660e1b30c0d7e7d4a676351b2a8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <***@redhat.com>
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@list

Loading...