Discussion:
Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run
Code Review
2017-08-22 20:07:01 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: place bonding defaults under /var/run
......................................................................


Patch Set 2: Code-Review+2

--
To view, visit https://gerrit.ovirt.org/80804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-***@lists.fedorahoste
Code Review
2017-08-22 20:07:15 UTC
Permalink
From Dan Kenigsberg <***@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80804 )

Change subject: net: place bonding defaults under /var/run
......................................................................


net: place bonding defaults under /var/run

vdsm-tool places bonding-defaults.json under /usr/share. However,
the proper place to store application data that is generated every boot
is under /var/run.

Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Bug-Url: https://bugzilla.redhat.com/1482014
Signed-off-by: Dan Kenigsberg <***@redhat.com>
Signed-off-by: Edward Haas <***@redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/netinfo/bonding.py
M lib/vdsm/tool/configurators/bond_defaults.py
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Looks good to me, but someone else must approve
Edward Haas: Verified



--
To view, visit https://gerrit.ovirt.org/80804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <***@redhat.com>
Gerrit-Reviewer: gerrit-hooks <***@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email to vds

Loading...